Make settings dialog full screen on mobile with a nav toggle #111

Open
miro wants to merge 1 commit from claude/mobile-settings-sidebar-toggle-2f98a5 into main
Owner

The settings dialog's nav sidebar was hidden below md with no way to open it.

  • Add a mobile-only toggle button in the dialog header that opens the nav as an overlay; selecting an item closes it.
  • Make the dialog full screen on mobile; desktop layout is unchanged.
The settings dialog's nav sidebar was hidden below `md` with no way to open it. - Add a mobile-only toggle button in the dialog header that opens the nav as an overlay; selecting an item closes it. - Make the dialog full screen on mobile; desktop layout is unchanged.
Make settings dialog full screen on mobile with a nav toggle
All checks were successful
CI / lint (pull_request) Successful in 32s
CI / format (pull_request) Successful in 30s
CI / knip (pull_request) Successful in 45s
CI / typecheck (pull_request) Successful in 54s
CI / docker (arm64, docker-arm64) (pull_request) Successful in 27s
CI / build (pull_request) Successful in 47s
CI / docker (amd64, docker-amd64) (pull_request) Successful in 20s
CI / manifest (pull_request) Has been skipped
CI / deploy-test (pull_request) Has been skipped
E2E / playwright (pull_request) Successful in 2m19s
CI / test (pull_request) Successful in 48s
f031e21539
All checks were successful
CI / lint (pull_request) Successful in 32s
CI / format (pull_request) Successful in 30s
CI / knip (pull_request) Successful in 45s
CI / typecheck (pull_request) Successful in 54s
CI / docker (arm64, docker-arm64) (pull_request) Successful in 27s
CI / build (pull_request) Successful in 47s
CI / docker (amd64, docker-amd64) (pull_request) Successful in 20s
CI / manifest (pull_request) Has been skipped
CI / deploy-test (pull_request) Has been skipped
E2E / playwright (pull_request) Successful in 2m19s
CI / test (pull_request) Successful in 48s
This pull request has changes conflicting with the target branch.
  • apps/app/src/components/settings-dialog.tsx
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin claude/mobile-settings-sidebar-toggle-2f98a5:claude/mobile-settings-sidebar-toggle-2f98a5
git switch claude/mobile-settings-sidebar-toggle-2f98a5

Merge

Merge the changes and update on Forgejo.
git switch main
git merge --no-ff claude/mobile-settings-sidebar-toggle-2f98a5
git switch claude/mobile-settings-sidebar-toggle-2f98a5
git rebase main
git switch main
git merge --ff-only claude/mobile-settings-sidebar-toggle-2f98a5
git switch claude/mobile-settings-sidebar-toggle-2f98a5
git rebase main
git switch main
git merge --no-ff claude/mobile-settings-sidebar-toggle-2f98a5
git switch main
git merge --squash claude/mobile-settings-sidebar-toggle-2f98a5
git switch main
git merge --ff-only claude/mobile-settings-sidebar-toggle-2f98a5
git switch main
git merge claude/mobile-settings-sidebar-toggle-2f98a5
git push origin main
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
miro/files!111
No description provided.